Skip to content

Conversation

@georgesittas
Copy link
Contributor

No description provided.

@georgesittas georgesittas requested a review from a team September 30, 2025 12:07
@georgesittas georgesittas force-pushed the jo/respect_quoting_setting_in_dbt branch 9 times, most recently from 84e8e59 to 573bfbc Compare October 2, 2025 14:08
Copy link
Contributor

@themisvaltinos themisvaltinos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, only the tests to adapt

@georgesittas georgesittas force-pushed the jo/respect_quoting_setting_in_dbt branch 3 times, most recently from 3befbc7 to 67e8455 Compare October 7, 2025 13:47
@georgesittas georgesittas force-pushed the jo/respect_quoting_setting_in_dbt branch from 67e8455 to edad6bc Compare October 8, 2025 17:58
@georgesittas georgesittas force-pushed the jo/respect_quoting_setting_in_dbt branch from edad6bc to e2cab74 Compare October 10, 2025 13:39
@georgesittas georgesittas marked this pull request as draft October 13, 2025 11:04
@georgesittas
Copy link
Contributor Author

This has been deprioritized for now in favor of some other tasks.

After discussing on Slack, we don't want to add quotes to every dbt model, because that's a massively breaking change. The idea we discussed was quoting only ref and source results or something, but I'm not sure if this will be a correct solution without testing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants